-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wrap
function which is the safe counterpart to unsafe_wrap
.
#52049
Merged
Merged
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
018cfdf
add `wrap` function which is the safe counterpart to `unsafe_wrap`.
MasonProtter e333739
update from review
MasonProtter 75c177d
fix docs
MasonProtter 4cac28b
fix typo
MasonProtter 2cdee6c
Merge branch 'master' into wrap
MasonProtter 3833df9
Update base/array.jl
MasonProtter 30d387a
Update base/array.jl
MasonProtter 3e85253
Update array.jl
MasonProtter 0e70a6d
Update array.jl
MasonProtter 60748b5
test with an offset memref
MasonProtter 3937b28
Update arrayops.jl
MasonProtter aafc381
fix memory size checks
MasonProtter 8fe2ff1
test for `MemoryRef` offsets causing oob
MasonProtter 6d1cb68
Merge branch 'master' into wrap
MasonProtter 94d1acd
fix typo
MasonProtter 3ddbcda
Include link to PR
MasonProtter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -458,6 +458,7 @@ export | |
vcat, | ||
vec, | ||
view, | ||
wrap, | ||
zeros, | ||
|
||
# search, find, match and related functions | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this check be behind a
@boundscheck
or should it just always be there?