Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify triangular multiplication code slightly #52393

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Simplify triangular multiplication code slightly #52393

merged 2 commits into from
Dec 5, 2023

Conversation

dkarrasch
Copy link
Member

@dkarrasch dkarrasch commented Dec 4, 2023 •
edited
Loading

This goes by the assumption that adjoint!(C, A) is never worse than copyto!(C, adjoint(A)), and similar for transposes.

After the edit, these should be purely cosmetic changes.

@dkarrasch dkarrasch added performance Must go faster linear algebra Linear algebra labels Dec 4, 2023
@dkarrasch dkarrasch requested a review from jishnub December 4, 2023 19:38
@jishnub
Copy link
Contributor

jishnub commented Dec 5, 2023

copyto!(dest, ::Adjoint) already calls adjoint! internally after #51650, so IIUC this is equivalent to _at_copyto!

@dkarrasch
Copy link
Member Author

True, thanks. I'll go forward and simplify some of the touched lines here to use just copyto!.

@dkarrasch dkarrasch changed the title Make copyto! use adjoint!/transpose! when appropriate Simplify triangular multiplication code slightly Dec 5, 2023
@dkarrasch dkarrasch added the merge me PR is reviewed. Merge when all tests are passing label Dec 5, 2023
@LilithHafner LilithHafner merged commit 2ef056a into master Dec 5, 2023
8 of 10 checks passed
@LilithHafner LilithHafner deleted the dk/adjortrans! branch December 5, 2023 15:39
@LilithHafner LilithHafner removed merge me PR is reviewed. Merge when all tests are passing performance Must go faster labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jishnub jishnub Awaiting requested review from jishnub

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkarrasch @jishnub @LilithHafner