[release-1.10] switch cache tracking from mtime to fsize & hash #52728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Florian <26469701+fatteneder@users.noreply.github.com>
fatteneder
reviewed
Jan 4, 2024
| @@ -2491,7 +2496,8 @@ end | |||
| struct CacheHeaderIncludes | |||
| id::PkgId | |||
| filename::String | |||
| mtime::Float64 | |||
There was a problem hiding this comment.
The patch from #50918 (comment) removed mtime, but we later added it again, because otherwise we break how people use include_dependency. I think we need to restore here too.
Also see #52161 for a discussion.
|
This here was not included in the original patch, but should also be included (line nr 2509/2515) > totbytes = read(f, Int64) # total bytes for file dependencies + preferences
totbytes = Int64(read(f, UInt64)) # total bytes for file dependencies + preferences |
|
We can avoid needing to do this because https://github.com/julia-actions/setup-julia/releases/tag/v1.9.5 closed #50667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup version of @fatteneder's patch here #50918 (comment)
Caching
/compiledin CI works great in 1.11 because of #49866 which moved away from mtime tracking to fsize and file hash tracking.1.10 is in the awkward position of having more stdlibs out of the sysimage and still using mtime, so it's actually a noticeable regression in CI cache effectiveness julia-actions/cache#85
Note that this also removes the current special casing check skip for stdlibs. i.e.
Skipping mtime check for file $f used by $cachefile, since it is a stdlibFor this to be a viable patch backport it needs to be very safe.
Related #50667