Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPLCompletions: PATH caching tweaks #52893

Merged
merged 8 commits into from
Jan 14, 2024
Merged

REPLCompletions: PATH caching tweaks #52893

merged 8 commits into from
Jan 14, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jan 13, 2024 •
edited
Loading

Followup to #52833

Fixes #52890

@IanButterworth IanButterworth mentioned this pull request Jan 13, 2024
Closed
@IanButterworth IanButterworth changed the title fix path cache cond REPLCompletions: PATH caching tweaks Jan 13, 2024
@IanButterworth IanButterworth mentioned this pull request Jan 13, 2024
Merged
vtjnash
vtjnash approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@IanButterworth @vtjnash
Update stdlib/REPL/src/REPLCompletions.jl
4d01853 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2024
@IanButterworth IanButterworth merged commit eadec43 into JuliaLang:master Jan 14, 2024
5 of 7 checks passed
@IanButterworth IanButterworth deleted the ib/fix_path_cache_cond branch January 14, 2024 15:58
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2024
@IanButterworth IanButterworth mentioned this pull request Jan 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConcurrencyViolationError("lock must be held") during repl shell completions
2 participants
@IanButterworth @vtjnash