try improving check_top_bit error message #53166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
approved these changes
Feb 3, 2024
|
Do you want to merge, or are we waiting for input from more people? |
vtjnash
pushed a commit
that referenced
this pull request
Feb 29, 2024
Used in some packages (e.g. rfourquet/BitIntegers.jl) Renamed in #53166
tecosaur
pushed a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
Used in some packages (e.g. rfourquet/BitIntegers.jl) Renamed in JuliaLang#53166
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Apr 13, 2024
Used in some packages (e.g. rfourquet/BitIntegers.jl) Renamed in JuliaLang#53166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30247
@staticfloat this was your issue, so what do you think of this? I think the main problem was already solved (showing the wrong type), but I am wondering if this wording is still clearer, since it tries to align it with functions users might actually have encountered (trunc, convert, signbit)