Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports release 1.10 #53201

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Backports release 1.10 #53201

merged 6 commits into from
Feb 6, 2024

Conversation

KristofferC
Copy link
Sponsor Member

pablosanjose and others added 5 commits February 6, 2024 11:46
@pablosanjose
Ensure elision of require_one_based_indexing with high-dim array vi…
ff295ca 
…ews (#53091)

Closes #49332

---------

Co-authored-by: Denis Barucic <barucic.d@gmail.com>
(cherry picked from commit 9edf1dd)
@MasonProtter
Try to fix incorrect documentation of nthreads (#53117)
e1af4a9 
Since #49094, the docstring of
`nthreads` has been incorrect. It currently states that

> The threads in default have id numbers `1:nthreads(:default)`.

whereas that is no longer true:
```julia
julia> filter(i -> Threads.threadpool(i) == :interactive, 1:Threads.maxthreadid())
3-element Vector{Int64}:
 1
 2
 3

julia> filter(i -> Threads.threadpool(i) == :default, 1:Threads.maxthreadid())
6-element Vector{Int64}:
 4
 5
 6
 7
 8
 9
```

(cherry picked from commit 95ae27f)
@jishnub
Fix variable name in scaling an AbstractTriangular with zero alpha (#…
93a596e 
…52855)

There is no `C` defined in these methods, so this branch used to error.

(cherry picked from commit c5d7b87)
@aviatesk
[REPLCompletions] enable completions for using Module.Inner| (#52952)
a1ad1ba 
(cherry picked from commit a0d55cd)
@jishnub
Inplace transpose for unit Triangular may skip diagonal (#53101)
2ef3842 
Since the diagonal elements of a `UnitUpperTriangular` are given by
`onelement`, these should be unchanged under `transpose/adjoint`, and we
don't need to access these elements in the parent array when performing
in-place operations.

Fixes
```julia
julia> using LinearAlgebra

julia> M = Matrix{BigFloat}(undef, 2, 2);

julia> M[1,2] = 3;

julia> U = UnitUpperTriangular(M)
2×2 UnitUpperTriangular{BigFloat, Matrix{BigFloat}}:
 1.0  3.0
  ⋅   1.0

julia> transpose!(U)
ERROR: UndefRefError: access to undefined reference
Stacktrace:
 [1] getindex
   @ ./essentials.jl:882 [inlined]
 [2] getindex
   @ ./array.jl:915 [inlined]
 [3] copytri!
   @ ~/packages/julias/julia-latest/share/julia/stdlib/v1.11/LinearAlgebra/src/matmul.jl:414 [inlined]
 [4] transpose!(A::UnitUpperTriangular{BigFloat, Matrix{BigFloat}})
   @ LinearAlgebra ~/packages/julias/julia-latest/share/julia/stdlib/v1.11/LinearAlgebra/src/triangular.jl:470
 [5] top-level scope
   @ REPL[5]:1
```
After this PR:
```julia
julia> transpose!(U)
2×2 UnitLowerTriangular{BigFloat, Matrix{BigFloat}}:
 1.0   ⋅
 3.0  1.0
```

(cherry picked from commit cc74d24)
@KristofferC KristofferC added the release Release management and versioning. label Feb 6, 2024
@xgdgsc
fix bus error on smaller readonly file in unix (#44354)
6fcff37 
Fixes: #28245
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Stefan Karpinski <stefan@karpinski.org>
(cherry picked from commit ead627e)
@KristofferC KristofferC merged commit 4745ef8 into release-1.10 Feb 6, 2024
4 of 6 checks passed
@KristofferC KristofferC deleted the backports-release-1.10 branch February 6, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release Release management and versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KristofferC @pablosanjose @MasonProtter @jishnub @aviatesk @xgdgsc