Revert "More consistent return value for annotations" #53309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e1a76bb.
vtjnash
added
ci
|
Can we work out more about why/how #53281 has actually caused an issue? I'm struggling to work out how it could have caused the problem it seems to have. |
vtjnash
deleted the
revert-53281-more-consistent-annotated-return-forms
branch
tecosaur
added a commit
to tecosaur/julia
that referenced
this pull request
Feb 14, 2024
This reverts commit 81c3474.
tecosaur
added a commit
to tecosaur/julia
that referenced
this pull request
Feb 19, 2024
This reverts commit 81c3474.
KristofferC
pushed a commit
to tecosaur/julia
that referenced
this pull request
Feb 19, 2024
This reverts commit 81c3474.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #53281 as it appears to have broken CI on all subsequent commits: #53281 (comment)
According to the CI logs, it is this test that aborts early on in the rr-trace log: