Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rare GC segfault coming from bug in mark-loop (alternative to 53351) #53353

Closed
wants to merge 1 commit into from

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Feb 15, 2024

Should fix #52757, #53026 and #53350.

Removes some of the awkwardness from #53351 but does require waiting for all threads to join at the end of mark-loop.

@d-netto d-netto added GC Garbage collector bugfix This change fixes an existing bug labels Feb 15, 2024
@d-netto d-netto requested review from vtjnash and gbaraldi February 15, 2024 20:44
@vtjnash
Copy link
Member

vtjnash commented Feb 17, 2024

I think #53355 should fix all 3 of those now (there appeared to be actually 3 different issues on review of the code), without needing the full pthread_barrier-like construct added here, which might slow down the master thread slightly more (since it only needs to wait for its own turn to acquire the lock, rather than waiting for every thread to get a turn to acquire the lock)

@d-netto
Copy link
Member Author

d-netto commented Feb 17, 2024

SGTM. Will let it be superseded by #53355. We can re-open if needed.

@d-netto d-netto closed this Feb 17, 2024
@giordano giordano deleted the dcn-fix-rare-gc-segfault2 branch February 25, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfault in gc binarytree.jl test
2 participants