Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package naming guidelines to encourage consideration of the global namespace #53514

Merged
merged 10 commits into from
Mar 1, 2024
Merged

Update package naming guidelines to encourage consideration of the global namespace #53514

merged 10 commits into from
Mar 1, 2024

Conversation

LilithHafner
Copy link
Member

Adds a

Avoid using a distinctive name that is already in use in another unrelated project.

clause.

(Also adds a newline to make the list formatting uniform)

@LilithHafner LilithHafner changed the title Update package naming guidelines to encourage consideration of the global namespace Update package naming guidelines to encourage consideration of the global namespace [NEEDS COMMUNITY REVIEW] Feb 28, 2024
@LilithHafner LilithHafner mentioned this pull request Feb 28, 2024
Closed
@DilumAluthge DilumAluthge added docs This change adds or pertains to documentation packages Package management and loading labels Feb 28, 2024
mbauman
mbauman reviewed Feb 28, 2024
View reviewed changes
doc/src/tutorials/creating-packages.md Show resolved Hide resolved
doc/src/tutorials/creating-packages.md Outdated Show resolved Hide resolved
doc/src/tutorials/creating-packages.md Outdated Show resolved Hide resolved
LilithHafner and others added 3 commits February 28, 2024 21:32
@LilithHafner
Change the AlphaZero example to OpenSSL
cf2231e
@LilithHafner @danielwe
fix typo
37ab894 
Co-authored-by: Daniel Wennberg <daniel.wennberg@gmail.com>
@LilithHafner @mbauman
Clarify tkinter example
10676e1 
Co-authored-by: Matt Bauman <mbauman@juliahub.com>
@LilithHafner
Copy link
Member Author

This looks like consensus to me.

2 approving reviews by committers
2 days without objection after advertisement on Zulip and Slack (both in general and in the package registration channels) and in a relevant ongoing discussion in PR to General.
14 +1 reactions & 0 negative reactions or objections beyond resolved wording fixups.

@LilithHafner LilithHafner changed the title Update package naming guidelines to encourage consideration of the global namespace [NEEDS COMMUNITY REVIEW] Update package naming guidelines to encourage consideration of the global namespace Mar 1, 2024
@LilithHafner LilithHafner merged commit c703a17 into master Mar 1, 2024
5 of 8 checks passed
@LilithHafner LilithHafner deleted the LilithHafner-patch-1 branch March 1, 2024 17:58
tecosaur pushed a commit to tecosaur/julia that referenced this pull request Mar 4, 2024
@LilithHafner @danielwe
@mbauman @tecosaur
Update package naming guidelines to encourage consideration of the gl…
ce9a32b 
…obal namespace (JuliaLang#53514)

Co-authored-by: Daniel Wennberg <daniel.wennberg@gmail.com>
Co-authored-by: Matt Bauman <mbauman@juliahub.com>
@goerz goerz mentioned this pull request Mar 27, 2024
Closed
mkitti pushed a commit to mkitti/julia that referenced this pull request Apr 13, 2024
@LilithHafner @danielwe
@mbauman @mkitti
Update package naming guidelines to encourage consideration of the gl…
23a2e25 
…obal namespace (JuliaLang#53514)

Co-authored-by: Daniel Wennberg <daniel.wennberg@gmail.com>
Co-authored-by: Matt Bauman <mbauman@juliahub.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinghvi17 asinghvi17 asinghvi17 left review comments

@danielwe danielwe danielwe left review comments

@stillyslalom stillyslalom stillyslalom left review comments

@KristofferC KristofferC KristofferC left review comments

@ViralBShah ViralBShah ViralBShah approved these changes

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation packages Package management and loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LilithHafner @mbauman @ViralBShah @KristofferC @stillyslalom @danielwe @asinghvi17 @DilumAluthge