Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change how we handle unions of missings and other types in unitary functions #53616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Mar 6, 2024

Follow up to #53602 (comment)
all the related need_to_handle_undef_sparam should now pass if this is right

@oscardssmith oscardssmith added the bugfix This change fixes an existing bug label Mar 8, 2024
@oscardssmith
Copy link
Member

is this ready to merge?

@oxinabox
Copy link
Contributor Author

It seems the CI failures are legit

@martinholters
Copy link
Member

Aren't the ::Type{Missing} methods still needed? (Or a branch to deal with T==Missing to avoid calling nonmissingtype_checked on it.)
OTOH, the ::Type{Any} might not be needed anymore to prevent a stack overflow, as the nonmissingtype_checked will throw in the ::Type{>:Missing} method. (But the more specific error might still be worth it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants