Commits on Apr 29, 2024

1. Specialised substring equality for annotated strs …

   The fact that only a string without annotations is equal to a
   non-annotated string (in order to preserve the transitivity of
   equality), makes the generic fallback methods for string comparison
   insufficient.
   
   As such, ==(::AnnoatedString, ::AbstractString) is implemented in
   annotated.jl, but this issue re-appears when dealing with substrings.
   
   The obvious solution is to just implement a specialised method for
   substrings. This does seem potentially a bit whack-a-mole, but I'm
   worried that cleverer solutions might come with subtle issues of their
   own. For now, let's try the simple and obvious solution, and improve it
   later if we can work out a nicer way of handling this issue in general.

   

   tecosaur committed Apr 29, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6f27021
   • Browse repository at this point

   Copy the full SHA

   6f27021 View commit details

   Browse the repository at this point in the history