Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root globals in toplevel exprs #54433

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Root globals in toplevel exprs #54433

merged 6 commits into from
Sep 25, 2024

Commits on Sep 23, 2024

  1. Always root the contents in expression, regardless if they are top le… 

    …vel or not.
    @gbaraldi @giordano
    gbaraldi authored and giordano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    919b6ad View commit details
    Browse the repository at this point in the history

  2. Update tests slightly

    @gbaraldi @giordano
    gbaraldi authored and giordano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2b2420c View commit details
    Browse the repository at this point in the history

  3. Instead of permanently rooting, make the global and marked + in the r… 

    …emset.
    @gbaraldi @giordano
    gbaraldi authored and giordano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c392082 View commit details
    Browse the repository at this point in the history

  4. gc_setmark should check if the object belongs to a image

    @gbaraldi @giordano
    gbaraldi authored and giordano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0239e33 View commit details
    Browse the repository at this point in the history

  5. Revert back to globally rooting the expr global since it's simpler an… 

    …d does work
    @gbaraldi
    gbaraldi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5965407 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Revert changes taht are no longer used in the PR

    @gbaraldi
    gbaraldi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    49df6e9 View commit details
    Browse the repository at this point in the history