Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Use GetModuleHandleExW to locate libjulia.dll #54617

Merged

Commits on May 29, 2024

  1. CLI: Use GetModuleHandleExW to locate libjulia.dll

    This should be a more reliable look-up, since this will directly report
    the path of the currently-executing libjulia.dll.
    
    Without this change, LoadLibraryW depends on the system library search order.
    When the top-level executable is adjacent to libjulia.dll (as it is for our
    binary distribution usually), then that search should be OK.
    
    However, applications that use Julia as a library can end up searching the
    system PATH before making it to the correct lib/julia directory, causing us
    to load the wrong version of libjulia.dll. In many cases, that extra load is
    benign due to the stricter separation of libraries/symbols on Windows,
    but in general it's likely to be the cause of subtle bugs.
    topolarity committed May 29, 2024
    Configuration menu
    Copy the full SHA
    44cbb67 View commit details
    Browse the repository at this point in the history