Revert "cleanup MemoryRef (#54647)"
#54680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it was just one test function that I forgot to update (so all the functionality worked as intended), and which was used enough times to cause the length of the error log to go above the 2mb limit and truncate. As such, I think it's worth seeing if #54681 fixes it fully and if so, merging rather than reverting. |
|
Oscar says he'll fix it tomorrow, so merging the revert in the meantime. |
oscardssmith
added a commit
to oscardssmith/julia
that referenced
this pull request
Jun 5, 2024
…)" This reverts commit c8ae7a0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #54647
This reverts commit fa038d9. The commit broke CI across all platforms.