Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix var name in reseteof(s::BufferStream) #54859

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

Evidently not covered by tests etc. (yet)

@IanButterworth IanButterworth added the needs tests Unit tests are required for this change label Jun 20, 2024
@IanButterworth IanButterworth removed the needs tests Unit tests are required for this change label Jun 20, 2024
@IanButterworth IanButterworth marked this pull request as ready for review June 20, 2024 15:44
@IanButterworth
Copy link
Sponsor Member Author

This seems like a clear error and the test now covers the correction so I'll mark it for merge

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Jun 20, 2024
@vtjnash vtjnash merged commit 3de5e5d into JuliaLang:master Jun 21, 2024
8 of 9 checks passed
@vtjnash vtjnash added the backport 1.11 Change should be backported to release-1.11 label Jun 21, 2024
@IanButterworth IanButterworth deleted the ib/reset_eof_fix branch June 21, 2024 17:04
KristofferC pushed a commit that referenced this pull request Jun 22, 2024
Evidently not covered by tests etc. (yet)

(cherry picked from commit 3de5e5d)
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Jun 23, 2024
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants