Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix concurrent module loading return value #54898

Merged
merged 2 commits into from
Jul 7, 2024
Merged

fix concurrent module loading return value #54898

merged 2 commits into from
Jul 7, 2024

Commits on Jun 24, 2024

  1. fix concurrent module loading return value 

    Previously this might return `nothing` which would confuse the caller of
`start_loading` which expects that to mean the Module didn't load. It is
not entirely clear if this code ever worked, even single-threaded.

Fix #54813
    @vtjnash
    vtjnash committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9d7d27b View commit details
    Browse the repository at this point in the history

  2. fixup! fix concurrent module loading return value

    @vtjnash
    vtjnash committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e78a342 View commit details
    Browse the repository at this point in the history