Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant print method for Splat #55494

Merged
merged 2 commits into from
Aug 18, 2024
Merged

remove redundant print method for Splat #55494

merged 2 commits into from
Aug 18, 2024

Conversation

matthias314
Copy link
Contributor

I think that print is redundant here. The docstring for print says:

print falls back to calling show, so most types should just define show.

vtjnash
vtjnash reviewed Aug 14, 2024
View reviewed changes
base/operators.jl Outdated Show resolved Hide resolved
@matthias314 @vtjnash
use show for showing splat function instead of print
2d9869e 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@matthias314
Copy link
Contributor Author

Thanks! Shall I combine both commits into one?

@jishnub
Copy link
Contributor

jishnub commented Aug 15, 2024

That's not necessary, as PR commits are usually squashed when they're merged.

@nsajko nsajko added the display and printing Aesthetics and correctness of printed representations of objects. label Aug 15, 2024
@LilithHafner
Copy link
Member

Thanks!

@LilithHafner LilithHafner merged commit 306cee7 into JuliaLang:master Aug 18, 2024
7 of 8 checks passed
KristofferC pushed a commit that referenced this pull request Sep 12, 2024
@matthias314
remove redundant print method for Splat (#55494)
4b03d27 
also a related bugfix by Jameson Nash <vtjnash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthias314 @jishnub @LilithHafner @vtjnash @nsajko