add digits keyword argument to format_bytes
#55495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
giordano
reviewed
Aug 15, 2024
base/timing.jl
Outdated
Comment on lines
158
to
159
| julia> Base.format_bytes(10000; sigdigits=1) | ||
| "9.8 KiB" |
There was a problem hiding this comment.
Am I missing something or these are two significant digits? Compare with round:
julia> round(10000 / 1024; sigdigits=1)
10.0
julia> round(10000 / 1024; sigdigits=2)
9.8There was a problem hiding this comment.
Okay, the docs for Ryu.writefixed says:
precision: minimum number of significant digits to be included in the decimal string; extra '0'
characters will be added for padding if necessary
So it is the number of sig digits of the decimals I guess.
There was a problem hiding this comment.
That's what round calls "digits":
julia> round(10000 / 1024; digits=0)
10.0
julia> round(10000 / 1024; digits=1)
9.8
julia> round(10000 / 1024; digits=3)
9.766
KristofferC
changed the title
sigdigits keyword argument to format_bytesdigits keyword argument to format_bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.