split internal dates methods into separate functions

stdlib/Dates/src/accessors.jl

@@ -2,47 +2,47 @@
 
 # Convert # of Rata Die days to proleptic Gregorian calendar y,m,d,w
 # Reference: https://www.researchgate.net/profile/Peter-Baum/publication/316558298_Date_Algorithms/links/5f90c3f992851c14bcdb0da6/Date-Algorithms.pdf
-function yearmonthday(days)
+function _yearmonthday(days)
     z = days + 306; h = 100z - 25; a = fld(h, 3652425); b = a - fld(a, 4)
     y = fld(100b + h, 36525); c = b + z - 365y - fld(y, 4); m = div(5c + 456, 153)
     d = c - div(153m - 457, 5); return m > 12 ? (y + 1, m - 12, d) : (y, m, d)
 end
-function year(days)
+function _year(days)
    z = days + 306; h = 100z - 25; a = fld(h, 3652425); b = a - fld(a, 4)
    y = fld(100b + h, 36525); c = b + z - 365y - fld(y, 4); m = div(5c + 456, 153)
    return m > 12 ? y + 1 : y
 end
-function yearmonth(days)
+function _yearmonth(days)
     z = days + 306; h = 100z - 25; a = fld(h,3652425); b = a - fld(a,4)
     y = fld(100b + h, 36525); c = b + z - 365y - fld(y, 4); m = div(5c + 456, 153)
     return m > 12 ? (y + 1, m - 12) : (y, m)
 end
-function month(days)
+function _month(days)
     z = days + 306; h = 100z - 25; a = fld(h,3652425); b = a - fld(a,4)
     y = fld(100b + h, 36525); c = b + z - 365y - fld(y, 4); m = div(5c + 456, 153)
     return m > 12 ? m - 12 : m
 end
-function monthday(days)
+function _monthday(days)
     z = days + 306; h = 100z - 25; a = fld(h,3652425); b = a - fld(a,4)
     y = fld(100b + h, 36525); c = b + z - 365y - fld(y, 4); m = div(5c + 456, 153)
     d = c - div(153m - 457, 5); return m > 12 ? (m - 12, d) : (m, d)
 end
-function day(days)
+function _day(days)
     z = days + 306; h = 100z - 25; a = fld(h,3652425); b = a - fld(a,4)
     y = fld(100b + h, 36525); c = b + z - 365y - fld(y, 4); m = div(5c + 456, 153)
     return c - div(153m - 457, 5)
 end
 # https://en.wikipedia.org/wiki/Talk:ISO_week_date#Algorithms
 const WEEK_INDEX = (15, 23, 3, 11)
-function week(days)
+function _week(days)
     w = div(abs(days - 1), 7) % 20871
     c, w = divrem((w + (w >= 10435)), 5218)
     w = (w * 28 + WEEK_INDEX[c + 1]) % 1461
     return div(w, 28) + 1
 end
 
-function quarter(days)
-    m = month(days)
+function _quarter(days)
+    m = _month(days)
     return m < 4 ? 1 : m < 7 ? 2 : m < 10 ? 3 : 4
 end
 
@@ -52,11 +52,11 @@ value(dt::TimeType) = dt.instant.periods.value
 value(t::Time) = t.instant.value
 days(dt::Date) = value(dt)
 days(dt::DateTime) = fld(value(dt), 86400000)
-year(dt::TimeType) = year(days(dt))
-quarter(dt::TimeType) = quarter(days(dt))
-month(dt::TimeType) = month(days(dt))
-week(dt::TimeType) = week(days(dt))
-day(dt::TimeType) = day(days(dt))
+year(dt::TimeType) = _year(days(dt))
+quarter(dt::TimeType) = _quarter(days(dt))
+month(dt::TimeType) = _month(days(dt))
+week(dt::TimeType) = _week(days(dt))
+day(dt::TimeType) = _day(days(dt))
 hour(dt::DateTime)   = mod(fld(value(dt), 3600000), 24)
 minute(dt::DateTime) = mod(fld(value(dt), 60000), 60)
 second(dt::DateTime) = mod(fld(value(dt), 1000), 60)
@@ -70,9 +70,9 @@ nanosecond(t::Time) = mod(value(t), Int64(1000))
 
 dayofmonth(dt::TimeType) = day(dt)
 
-yearmonth(dt::TimeType) = yearmonth(days(dt))
-monthday(dt::TimeType) = monthday(days(dt))
-yearmonthday(dt::TimeType) = yearmonthday(days(dt))
+yearmonth(dt::TimeType) = _yearmonth(days(dt))
+monthday(dt::TimeType) = _monthday(days(dt))
+yearmonthday(dt::TimeType) = _yearmonthday(days(dt))
 
 # Documentation for exported accessors
 for func in (:year, :month, :quarter)

stdlib/Dates/src/conversions.jl

@@ -98,7 +98,7 @@ now(::Type{UTC}) = unix2datetime(time())
 Take the number of Rata Die days since epoch `0000-12-31T00:00:00` and return the
 corresponding `DateTime`.
 """
-rata2datetime(days) = DateTime(yearmonthday(days)...)
+rata2datetime(days) = DateTime(_yearmonthday(days)...)
 
 """
     datetime2rata(dt::TimeType) -> Int64

stdlib/Dates/src/io.jl

@@ -732,7 +732,7 @@ end
 function Base.print(io::IO, dt::Date)
     # don't use format - bypassing IOBuffer creation
     # saves a bit of time here.
-    y,m,d = yearmonthday(value(dt))
+    y,m,d = yearmonthday(dt)
     yy = y < 0 ? @sprintf("%05i", y) : lpad(y, 4, "0")
     mm = lpad(m, 2, "0")
     dd = lpad(d, 2, "0")