Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some loading / LazyArtifacts precompiles to the sysimage #55740

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

@IanButterworth IanButterworth commented Sep 11, 2024

Fixes #55725

These help LazyArtifacts mainly but seem beneficial for the sysimage.

master

% julia +nightly --start=no -e "using InteractiveUtils; @time @time_imports using MicroMamba"
      0.7 ms  Printf
     16.2 ms  Dates
      0.4 ms  Scratch
      0.7 ms  TOML
               ┌ 0.0 ms NetworkOptions.__init__()
      1.5 ms  NetworkOptions
               ┌ 0.9 ms MbedTLS_jll.__init__()
      3.3 ms  MbedTLS_jll
               ┌ 0.6 ms LibSSH2_jll.__init__()
      2.5 ms  LibSSH2_jll
               ┌ 1.1 ms LibGit2_jll.__init__()
      3.3 ms  LibGit2_jll
      8.5 ms  LibGit2
      6.3 ms  ArgTools
               ┌ 0.7 ms nghttp2_jll.__init__()
      2.4 ms  nghttp2_jll
               ┌ 0.7 ms LibCURL_jll.__init__()
      2.7 ms  LibCURL_jll
               ┌ 0.0 ms MozillaCACerts_jll.__init__()
      2.0 ms  MozillaCACerts_jll
               ┌ 0.0 ms LibCURL.__init__()
      1.1 ms  LibCURL
               ┌ 3.4 ms Downloads.Curl.__init__()
     18.7 ms  Downloads
      0.8 ms  Tar
               ┌ 0.1 ms p7zip_jll.__init__()
      2.8 ms  p7zip_jll
      0.3 ms  UUIDs
      0.2 ms  Logging
               ┌ 0.0 ms Pkg.__init__()
    180.1 ms  Pkg
      0.4 ms  LazyArtifacts
      7.7 ms  Preferences
      0.4 ms  JLLWrappers
               ┌ 128.4 ms micromamba_jll.__init__() 99.80% compilation time (9% recompilation)
    209.4 ms  micromamba_jll 99.54% compilation time (23% recompilation)
      0.5 ms  MicroMamba
  0.514519 seconds (1.26 M allocations: 73.194 MiB, 13.64% gc time, 41.43% compilation time: 25% of which was recompilation)

master with JuliaPackaging/LazyArtifacts.jl#1

% ./julia --start=no --trace-compile=stderr --trace-compile-timing -e "using InteractiveUtils; @time @time_imports using MicroMamba"
      0.5 ms  Printf
     15.0 ms  Dates
      0.3 ms  Scratch
     10.0 ms  LazyArtifacts
      1.0 ms  TOML
      7.2 ms  Preferences
      0.5 ms  JLLWrappers
               ┌ 545.2 ms micromamba_jll.__init__() 99.93% compilation time (88% recompilation)
    545.7 ms  micromamba_jll 99.84% compilation time (88% recompilation)
      0.4 ms  MicroMamba
  0.586889 seconds (763.19 k allocations: 40.931 MiB, 5.56% gc time, 92.84% compilation time: 88% of which was recompilation)

#55739 with JuliaPackaging/LazyArtifacts.jl#1

% ./julia --start=no -e "using InteractiveUtils; @time @time_imports using MicroMamba"
      0.7 ms  Printf
     21.5 ms  Dates
      0.5 ms  Scratch
     14.9 ms  LazyArtifacts
      0.9 ms  TOML
      8.7 ms  Preferences
      0.5 ms  JLLWrappers
               ┌ 44.7 ms micromamba_jll.__init__() 99.60% compilation time (3% recompilation)
     45.3 ms  micromamba_jll 98.17% compilation time (3% recompilation)
      0.4 ms  MicroMamba
  0.129260 seconds (177.54 k allocations: 9.573 MiB, 34.42% compilation time: 3% of which was recompilation)

This PR with #55739 and JuliaPackaging/LazyArtifacts.jl#1

% ./julia --start=no -e "using InteractiveUtils; @time @time_imports using MicroMamba"
      0.5 ms  Printf
     18.9 ms  Dates
      0.3 ms  Scratch
     11.9 ms  LazyArtifacts
      0.6 ms  TOML
      7.6 ms  Preferences
      0.8 ms  JLLWrappers
               ┌ 0.1 ms micromamba_jll.__init__()
      0.8 ms  micromamba_jll
      0.4 ms  MicroMamba
  0.054467 seconds (67.72 k allocations: 3.673 MiB)

@topolarity topolarity merged commit bf6962c into JuliaLang:master Sep 11, 2024
8 checks passed
@IanButterworth IanButterworth deleted the ib/lazy_precompiles branch September 11, 2024 23:34
kshyatt pushed a commit that referenced this pull request Sep 12, 2024
Fixes #55725

These help LazyArtifacts mainly but seem beneficial for the sysimage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

136x regression for LazyArtifacts
2 participants