Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple: fix bus error on smaller readonly file in unix #55859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Sep 24, 2024

Enables the fix for #28245 in #44354 for Apple now that the Julia bug is fixed by #55641.

Closes #28245

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Sep 24, 2024

Looks like this still runs into a different bug in stat:

SharedArrays(1) |        started at 2024-09-24T11:45:14.700
System max size of single shmem segment(MB) : 4
System max size of all shmem segments(MB) : 16
Requested size(MB) : 0
Please ensure requested size is within system limits.
If not, increase system limits and try again.
SharedArrays(1) |         failed at 2024-09-24T11:45:22.581
Error During Test at /Users/jameson/julia/test/testdefs.jl:24
  Got exception outside of a @test
  LoadError: stat returned zero type for a valid path
  Stacktrace:
    [1] error(s::String)
      @ Base ./error.jl:44
    [2] stat(fd::RawFD)
      @ Base.Filesystem ./stat.jl:180
    [3] stat
      @ ./iostream.jl:63 [inlined]
    [4] filesize(s::IOStream)
      @ Base ./iostream.jl:234
    [5] mmap(io::IOStream, ::Type{Array{Int64, 3}}, dims::Tuple{Int64, Int64, Int64}, offset::Int64; grow::Bool, shared::Bool)
      @ Mmap ~/julia/usr/share/julia/stdlib/v1.12/Mmap/src/Mmap.jl:214

@vtjnash vtjnash marked this pull request as draft September 24, 2024 15:55
@vtjnash vtjnash added filesystem Underlying file system and functions that use it system:mac Affects only macOS labels Sep 24, 2024
@vtjnash vtjnash changed the base branch from master to jn/fix-stat-PollingFileWatcher September 26, 2024 19:42
@vtjnash vtjnash force-pushed the jn/fix-stat-PollingFileWatcher branch 2 times, most recently from fb1b40f to f8d17e7 Compare September 30, 2024 19:01
Base automatically changed from jn/fix-stat-PollingFileWatcher to master October 1, 2024 14:41
Enables the fix for #28245 in #44354 for Apple now that the Julia bug is
fixed by #55641.

Closes #28245
@vtjnash vtjnash marked this pull request as ready for review October 1, 2024 14:44
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem Underlying file system and functions that use it merge me PR is reviewed. Merge when all tests are passing system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mmap bus error
1 participant