Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOML: Avoid type-pirating Base.TOML.Parser #55892

Merged
merged 2 commits into from
Sep 30, 2024
Merged

TOML: Avoid type-pirating Base.TOML.Parser #55892

merged 2 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. TOML: Avoid type-pirating Base.TOML.Parser 

    Since stdlibs can be duplicated but Base never is, `require_stdlib`
makes type piracy even more complicated than it normally would be.

To adapt, this changes `TOML.Parser` to be type defined by the TOML
stdlib, so that we can define methods on it without committing
type-piracy and avoid problems like Pkg.jl#4017
    @topolarity
    topolarity committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6efad7c View commit details
    Browse the repository at this point in the history

  2. Add definitions for internal TOML methods in Base 

    Despite being internal, these interfaces are used in a number of places
downstream, so it's best for TOML's parser type to have their interface
defined.
    @topolarity
    topolarity committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d4ac343 View commit details
    Browse the repository at this point in the history