Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add propagate_inbounds_meta to atomic genericmemory ops #55902

Merged
merged 1 commit into from
Oct 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions base/genericmemory.jl
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,13 @@ end

# get, set(once), modify, swap and replace at index, atomically
function getindex_atomic(mem::GenericMemory, order::Symbol, i::Int)
@_propagate_inbounds_meta
memref = memoryref(mem, i)
return memoryrefget(memref, order, @_boundscheck)
end

function setindex_atomic!(mem::GenericMemory, order::Symbol, val, i::Int)
@_propagate_inbounds_meta
T = eltype(mem)
memref = memoryref(mem, i)
return memoryrefset!(
Expand All @@ -342,6 +344,7 @@ function setindexonce_atomic!(
val,
i::Int,
)
@_propagate_inbounds_meta
T = eltype(mem)
memref = memoryref(mem, i)
return Core.memoryrefsetonce!(
Expand All @@ -354,11 +357,13 @@ function setindexonce_atomic!(
end

function modifyindex_atomic!(mem::GenericMemory, order::Symbol, op, val, i::Int)
@_propagate_inbounds_meta
memref = memoryref(mem, i)
return Core.memoryrefmodify!(memref, op, val, order, @_boundscheck)
end

function swapindex_atomic!(mem::GenericMemory, order::Symbol, val, i::Int)
@_propagate_inbounds_meta
T = eltype(mem)
memref = memoryref(mem, i)
return Core.memoryrefswap!(
Expand All @@ -377,6 +382,7 @@ function replaceindex_atomic!(
desired,
i::Int,
)
@_propagate_inbounds_meta
T = eltype(mem)
memref = memoryref(mem, i)
return Core.memoryrefreplace!(
Expand Down