Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL: make UndefVarError aware of imported modules #55932

Merged
merged 3 commits into from
Oct 2, 2024
Merged

REPL: make UndefVarError aware of imported modules #55932

merged 3 commits into from
Oct 2, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

Fixes #55914

(@v1.12) pkg>

julia> Pkg
ERROR: UndefVarError: `Pkg` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
Hint: Pkg is loaded but not imported in the active module `Main`.

julia> activate
ERROR: UndefVarError: `activate` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
Hint: a global variable of this name also exists in Pkg, which is loaded but not imported in the active module `Main`.

julia> import Pkg

julia> activate
ERROR: UndefVarError: `activate` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
Hint: a global variable of this name also exists in Pkg.

@IanButterworth IanButterworth added the backport 1.11 Change should be backported to release-1.11 label Sep 29, 2024
@giordano giordano added REPL Julia's REPL (Read Eval Print Loop) error messages Better, more actionable error messages labels Sep 30, 2024
@KristofferC KristofferC mentioned this pull request Sep 30, 2024
Merged
39 tasks
KristofferC added a commit that referenced this pull request Oct 1, 2024
@KristofferC
Backports release 1.11 (#55936)
4c87cb4 
Backported PRs:
- [x] #55849 <!-- Mmap: fix grow! for non file IOs -->
- [x] #55863 <!-- Update TaskLocalRNG docstring according to #49110 -->
- [x] #54433 <!-- Root globals in toplevel exprs -->
- [x] #55828 <!-- Fix some corner cases of `isapprox` with unsigned
integers -->
- [x] #55890 <!-- Profile: fix order of fields in heapsnapshot & improve
formatting -->
- [x] #55884 <!-- inference: add missing `TypeVar` handling for
`instanceof_tfunc` -->
- [x] #55881 <!-- Install terminfo data under /usr/share/julia -->
- [x] #55909 <!-- do not intentionally suppress errors in precompile
script from being reported or failing the result -->
- [x] #55355 <!-- relocation: account for trailing path separator in
depot paths -->
- [x] #55917 <!-- fix rawbigints OOB issues -->
- [x] #55892 <!-- TOML: Avoid type-pirating `Base.TOML.Parser` -->
- [x] #55798 <!-- Broadcast binary ops involving strided triangular -->
- [x] #55919 <!-- Limit `@inbounds` to indexing in the dual-iterator
branch in `copyto_unaliased!` -->

Contains multiple commits, manual intervention needed:
- [ ] #54009 <!-- allow extensions to trigger from packages in [deps]
-->
- [ ] #55509 <!-- Fix cong implementation to be properly random and not
just cycling. -->
- [ ] #55569 <!-- Add a docs section about loading/precomp/ttfx time
tuning -->
- [ ] #55824 <!-- Replace regex package module checks with actual code
checks -->

Non-merged PRs with backport label:
- [ ] #55932 <!-- REPL: make UndefVarError aware of imported modules -->
- [ ] #55910 <!-- Prevent extensions from blocking parallel
pre-compilation -->
- [ ] #55908 <!-- add logic to prefer loading modules that are already
loaded -->
- [ ] #55886 <!-- irrationals: restrict assume effects annotations to
known types -->
- [ ] #55871 <!-- lowering: don't reverse handler order in
`(pop-handler-list ...)` -->
- [ ] #55870 <!-- fix infinite recursion in `promote_type` for
`Irrational` -->
- [ ] #55867 <!-- update `hash` doc string: `widen` not required any
more -->
- [ ] #55851 <!-- [REPL] Fix #55850 by using `safe_realpath` instead of
`abspath` in `projname` -->
- [ ] #55813 <!-- Check for conflicting `@ccallable` name before JIT
registration -->
- [ ] #55743 <!-- doc: heap snapshot viewing -->
- [ ] #55741 <!-- Change annotations to use a NamedTuple -->
- [ ] #55534 <!-- Set stdlib sources as read-only during installation
-->
- [ ] #55499 <!-- propagate the terminal's `displaysize` to the
`IOContext` used by the REPL -->
- [ ] #55458 <!-- Allow for generically extracting unannotated string
-->
- [ ] #55457 <!-- Make AnnotateChar equality consider annotations -->
- [ ] #55220 <!-- `isfile_casesensitive` fixes on Windows -->
- [ ] #55169 <!-- `propertynames` for SVD respects private argument -->
- [ ] #54457 <!-- Make `String(::Memory)` copy -->
- [ ] #53957 <!-- tweak how filtering is done for what packages should
be precompiled -->
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
- [ ] #50813 <!-- More doctests for Sockets and capitalization fix -->
- [ ] #50157 <!-- improve docs for `@inbounds` and
`Base.@propagate_inbounds` -->
vtjnash
vtjnash reviewed Oct 1, 2024
View reviewed changes
base/experimental.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash approved these changes Oct 1, 2024
View reviewed changes
Copy link
Sponsor Member

@vtjnash vtjnash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text feels like a bit of a mouthful (particularly if we end up printing it a couple times), since we can pretty much assume that the module is loaded but not imported if the scope is Module (as otherwise we would not have had an UndefVarError). Maybe we can just wordsmith the default text a bit instead, based on the scope type?

e.g. "Hint: a global variable of this name may be made accessible by importing Pkg in the current active module $active"

@IanButterworth @vtjnash
suggestions
0984e42 
Co-Authored-By: Jameson Nash <vtjnash+github@gmail.com>
@IanButterworth IanButterworth merged commit fbb3e11 into JuliaLang:master Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@simeonschaub simeonschaub Awaiting requested review from simeonschaub

Assignees
No one assigned
Labels
backport 1.11 Change should be backported to release-1.11 error messages Better, more actionable error messages REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

confusing error when Pkg is not imported but REPL mode has been used
3 participants
@IanButterworth @vtjnash @giordano