Don't try to allocate new binding partitions from static show #56298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular static show is used inside the GC for profiling, which showed up as a segfault on CI, e.g. in https://buildkite.com/julialang/julia-master/builds/41407#0192b628-47f3-49f9-a081-cd2708eb6121
|
This code is still segfaulting on tests, so this PR doesn't seem to have fixed it enough: |
|
That's on musl, which has known corruption issues and the backtrace is different. Not convinced it's related. |
|
There is an attached coredump, if you are able to find that useful in this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular static show is used inside the GC for profiling, which showed up as a segfault on CI, e.g. in
https://buildkite.com/julialang/julia-master/builds/41407#0192b628-47f3-49f9-a081-cd2708eb6121.
GC check didn't catch it because that file is explicitly exempt: https://github.com/JuliaLang/julia/blob/master/src/Makefile#L504