Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying ispunct behavior difference between Julia and C in documentation #56727

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

Priynsh
Copy link
Contributor

@Priynsh Priynsh commented Dec 1, 2024

Fixes #56680. This PR updates the documentation for the ispunct function in Julia to explicitly note its differing behavior from the similarly named function in C.

edited documentation to point out the difference from a same named method in c (ispunct)
@Priynsh Priynsh marked this pull request as ready for review December 1, 2024 14:06
Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR! For example, '+', '<', '=', '>', '^', '', '|', '~'` are all punctuation according to C but not Julia.

Would you add ispunct('=') to the examples section as well, please?

base/strings/unicode.jl Outdated Show resolved Hide resolved
base/strings/unicode.jl Outdated Show resolved Hide resolved
implemented changes suggested :)
Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
@LilithHafner LilithHafner added docs This change adds or pertains to documentation merge me PR is reviewed. Merge when all tests are passing labels Dec 1, 2024
Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! We'll merge this once CI passes :)

@LilithHafner LilithHafner added the unicode Related to unicode characters and encodings label Dec 1, 2024
@LilithHafner LilithHafner merged commit ea42112 into JuliaLang:master Dec 1, 2024
10 checks passed
@LilithHafner LilithHafner removed the merge me PR is reviewed. Merge when all tests are passing label Dec 1, 2024
@Priynsh Priynsh deleted the ispunctdoc branch December 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation unicode Related to unicode characters and encodings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ispunct differs from the function with the same name in C, could be worth a note
2 participants