Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 [master] Bump the Distributed stdlib from 6c7cdb5 to c613685 #56825

Conversation

DilumAluthgeBot
Copy link
Contributor

Stdlib: Distributed
URL: https://github.com/JuliaLang/Distributed.jl
Stdlib branch: master
Julia branch: master
Old commit: 6c7cdb5
New commit: c613685
Julia version: 1.12.0-DEV
Distributed version: 1.11.0(Does not match)
Bump invoked by: @DilumAluthge
Powered by: BumpStdlibs.jl

Diff: JuliaLang/Distributed.jl@6c7cdb5...c613685

$ git log --oneline 6c7cdb5..c613685
c613685 Merge pull request #116 from JuliaLang/ci-caching
20e2ce7 Use julia-actions/cache in CI
9c5d73a Merge pull request #112 from JuliaLang/dependabot/github_actions/codecov/codecov-action-5
ed12496 Merge pull request #107 from JamesWrigley/remotechannel-empty
010828a Update .github/workflows/ci.yml
11451a8 Bump codecov/codecov-action from 4 to 5
8b5983b Merge branch 'master' into remotechannel-empty
729ba6a Fix docstring of `@everywhere` (#110)
af89e6c Adding better docs to exeflags kwarg (#108)
8537424 Implement Base.isempty(::RemoteChannel)
6a0383b Add a wait(::[Abstract]WorkerPool) (#106)
1cd2677 Bump codecov/codecov-action from 1 to 4 (#96)
cde4078 Bump actions/cache from 1 to 4 (#98)
6c8245a Bump julia-actions/setup-julia from 1 to 2 (#97)
1ffaac8 Bump actions/checkout from 2 to 4 (#99)
8e3f849 Fix RemoteChannel iterator interface (#100)
f4aaf1b Fix markdown errors in README.md (#95)
2017da9 Merge pull request #103 from JuliaLang/sf/sigquit_instead
07389dd Use `SIGQUIT` instead of `SIGTERM`

@DilumAluthge DilumAluthge added parallelism Parallel or distributed computation stdlib Julia's standard library labels Dec 14, 2024
@DilumAluthge
Copy link
Member

Bump @vchuravy

@vchuravy
Copy link
Member

I haven't reviewed most PRs that got merged, I don't have the bandwidth for Distributed.jl these days.
It looks like @ViralBShah has been looking at these.

@vchuravy vchuravy requested review from ViralBShah and removed request for vchuravy December 16, 2024 14:25
@DilumAluthge
Copy link
Member

Maybe also cc @jpsamaroo

@ViralBShah
Copy link
Member

Yes @jpsamaroo probably is best. Perhaps @JamesWrigley too. I only was able to look into some housekeeping

Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone wants to review functional changes in depth.
The following is a list of changes that do not include CI maintenance and document formatting changes.

  • BUG: fix undefined value error
    Fix RemoteChannel iterator interface #100
  • ENH: Use SIGQUIT instead of SIGTERM #103
  • API: Add a wait(::[Abstract]WorkerPool) #106
  • API: Implement Base.isempty(::RemoteChannel) #107
  • DOC: Adding better docs to exeflags kwarg for addprocs #108

Other CI maintenance and document formatting changes look good to me.


On a side note, I've found that it helps to quickly review a large number of commits
if we squash the commits by default and add categories to the commit messages.

I'm using scipy style: Writing the commit message

Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go, I would just keep an eye out to make sure the SIGQUIT changes don't cause any issues with CI cleanup (not that I would expect it to).

@DilumAluthge DilumAluthge merged commit 2ed1a41 into JuliaLang:master Dec 17, 2024
7 checks passed
@DilumAluthge DilumAluthge deleted the BumpStdlibs/Distributed-c613685-master branch December 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parallelism Parallel or distributed computation stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants