change argument order for rand! (fix #8246) #9092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API to fill randomly an array A is changed from rand!([rng], [::Range], A) to rand!([rng], A, [::AbstractArray]). Enabling [::AbstractArray] instead of only [::Range] depended on choosing first the argument order.
|
Note that this should not break code (only deprecation warnings in e.g. |
|
I'll switch my vote to get things moving faster. |
ViralBShah
added a commit
that referenced
this pull request
Nov 21, 2014
change argument order for rand! (fix #8246)
|
@rfourquet Thanks for all the rapid contributions! You've really helped move things along on our RNG front. |
|
:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API is
rand!([rng], [r::Range], A). There seems to be an almost consensus (cf. #8246) to putr::Rangeas last argument, and a preference to keeprngbeforeA, i.e:rand!([rng], A, [::Range]). This PR implements this solution, but can easily be changed torand!(A, [rng], [::Range])if a decision is made this way.Note:
r::Rangeis also changed tor::AbstractArray, to matchrand.