Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC root for func in jl_instantiate_staged #9111

Merged
merged 1 commit into from
Nov 22, 2014
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 22, 2014

Fixes #9099, I hope. CC @Keno, @JeffBezanson, @vtjnash. With this change, I was able to insert a jl_gc_collect() here without causing a segfault.

@vtjnash
Copy link
Member

vtjnash commented Nov 22, 2014

lgtm. otherwise the first argument to jl_apply isn't rooted

@timholy
Copy link
Member Author

timholy commented Nov 22, 2014

Thanks, @vtjnash. This is my first time using GC_PUSH macros, so I greatly appreciate your having taken the time to look at this. Am I right in thinking that all functions with jl_ in front of them might involve allocation, and hence you need to root anything they use? And conversely, in the gaps between jl_* functions you should not require gc roots?

timholy added a commit that referenced this pull request Nov 22, 2014
Add GC root for func in jl_instantiate_staged
@timholy timholy merged commit b82aa82 into master Nov 22, 2014
@timholy timholy deleted the teh/staged_root branch November 22, 2014 19:26
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6fcbf1b on teh/staged_root into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stagedfunction segfault
3 participants