-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Linux installation to copy-paste #928
Conversation
Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR928/ |
The downside is that this will have to be updated every time the Julia recommended version changes. |
Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com>
"$PWD"/julia-1.4.2/bin/julia |
downloads/platform.md
Outdated
``` | ||
wget https://julialang-s3.julialang.org/bin/linux/x64/1.4/julia-1.4.2-linux-x86_64.tar.gz | ||
tar -xvzf julia-1.4.2-linux-x86\_64.tar.gz | ||
ln -s "$PWD"/julia-1.4.2/bin/julia ~/.local/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in PATH
by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of weird that these instructions are just run in some unspecified directory. Presumably the user's home directory? Maybe a little info about where to run this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a place we should download it to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, but maybe a word about "pick a place where you want the Julia directory to live—this can be your home directory or maybe a ~/dev
directory if you prefer that."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you apt-get
or install a Windows binary, it just goes somewhere and that's where it is. What's a good default for us to do here? Anyone who cares where it goes will know what to do: the instructions are for the other audience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not say that run the command from the directory you want it in?
@tlienart We have a way to make this generic, IIRC. So that it doesn't need changing with every release. |
@ViralBShah im lacking context here but if you open an issue explaining what needs to be done & assign it to me I'll get it done asap |
Sorry - if you look at the PR, it has hard-coded Julia versions, which will have to be changed every time there's a new release. I thought onthe downloads page we have variables that we can use to refer to the latest stable release. |
Yes we do, though not sure if they will work in this context. |
Ah right in the code you mean? Yes yes that can be done; ok I'll try that today |
Except for the python dependency, I still believe #926
provides better and generic instruction to this. And If a shell script oneliner for Linux/macOS is wanted, we could save us some efforts and borrow jill.sh (cc: @abelsiqueira) |
@ViralBShah |
In light of #928 (comment) should we close this PR and open another one with the one-liner from PS: this is maybe an unrelated concern but would it be a security concern that the "blessed" download way would be dependent upon an external repo not part of the |
Yes, I don't think we should list that in such a prominent place. In particular it doesn't look good that you first have to install python and then a python package to finally install Julia. Maybe we could instead support and maintain something like Rust's rustup.sh. |
Just pointing out that Jill is a bash script, so there is no need to install python before: https://github.com/abelsiqueira/jill (maybe I should officially name it Jill.sh?) If you prefer I can transfer ownership to JuliaLang. |
Install Julia is super easy. For
Maybe, if there's someone in Julialang willing to and he happens to have some time. |
* Make instructions use the current stable version This corresponds to the request in #928 to have instructions that can depend on the `stable_version` variable. #928 could be eventually adapted to use the same ideas * Update platform.md * simplifying a bit * small fixes Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
I would be happy to move |
Not sure what to do here. |
I'd be happy to look at jill and decide if we should include it in a more official capacity, but blocking better Linux install instructions on that seems kind of unnecessary. How about we improve the Linux install instructions and then separately consider something like that? |
Co-authored-by: Zlatan Vasović <zlatanvasovic@gmail.com>
I think the easiest way to get this merged is to ask people to download and untar in their home directory and then run with |
I agree with @StefanKarpinski. I started a discussion on abelsiqueira/jill#33. |
I am merging it right now as it is a significant improvement. Can always make it better. |
|
||
``` | ||
wget https://julialang-s3.julialang.org/bin/linux/x64/1.4/julia-{{ stable_release }}-linux-x86_64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.4
here should be replaced with some placeholder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ stable_release_short }}
It seems strange to merge a "copy paste" solution that doesn't work and has open unaddressed review comments. |
No description provided.