Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MassInstallAction: Install the CI workflow on this repository #41

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 24, 2020

This pull request sets up the CI workflow on this repository.

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d79efa2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 34c9c7b differs from pull request most recent head 1dd3774. Consider uploading reports for the commit 1dd3774 to get more accurate results

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   80.64%           
=========================================
  Files             ?        3           
  Lines             ?      124           
  Branches          ?        0           
=========================================
  Hits              ?      100           
  Misses            ?       24           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ViralBShah ViralBShah force-pushed the massinstallaction/set-up-CI branch 2 times, most recently from 92f466c to 67b2ab8 Compare August 7, 2022 15:18
@ViralBShah
Copy link
Contributor

The tests run fine locally for me, but not in CI. @daviehh Since you provided the PR that made this package run on my mac, I wonder if you have any thoughts here.

@ViralBShah ViralBShah force-pushed the massinstallaction/set-up-CI branch from b57ba9f to 1dd3774 Compare August 7, 2022 16:25
@ViralBShah
Copy link
Contributor

Merging this to switch on the CI, and subsequent PRs need to make the CI pass.

@ViralBShah ViralBShah merged commit e918be4 into master Aug 7, 2022
@ViralBShah ViralBShah deleted the massinstallaction/set-up-CI branch August 7, 2022 16:26
@ViralBShah
Copy link
Contributor

@giordano @staticfloat Would you know why these tests that are basically dlopening Accelerate and calling simple functions, failing in CI, but would pass locally?

@daviehh
Copy link
Contributor

daviehh commented Aug 7, 2022

According to the report in #43 (comment), it may be a macos bug: some version in of macos 11.x may have some bugs that missed some symbols; all test runs fine on 12.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants