Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of internal caches broken on 1.7 (and 1.6 soon) #81

Closed
vchuravy opened this issue Oct 20, 2021 · 6 comments · Fixed by #85
Closed

Use of internal caches broken on 1.7 (and 1.6 soon) #81

vchuravy opened this issue Oct 20, 2021 · 6 comments · Fixed by #85

Comments

@vchuravy
Copy link

For context: JuliaLang/julia#42309

Helium all electron: Error During Test at /home/runner/work/DFTK.jl/DFTK.jl/test/helium_all_electron.jl:5
  Got exception outside of a @test
  UndefVarError: Abuf not defined
  Stacktrace:
    [1] tiled_blasmul!(tile_size::Int64, α::Float64, A::Matrix{ComplexF64}, B::SubArray{ComplexF64, 2, Matrix{ComplexF64}, Tuple{UnitRange{Int64}, Base.OneTo{Int64}}, false}, β::Float64, C::SubArray{ComplexF64, 2, Matrix{ComplexF64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false})
      @ ArrayLayouts ~/.julia/packages/ArrayLayouts/O51Gr/src/muladd.jl:101
    [2] materialize!(M::ArrayLayouts.MulAdd{ArrayLayouts.DenseColumnMajor, ArrayLayouts.ColumnMajor, ArrayLayouts.ColumnMajor, Float64, Matrix{ComplexF64}, SubArray{ComplexF64, 2, Matrix{ComplexF64}, Tuple{UnitRange{Int64}, Base.OneTo{Int64}}, false}, SubArray{ComplexF64, 2, Matrix{ComplexF64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}})
      @ ArrayLayouts ~/.julia/packages/ArrayLayouts/O51Gr/src/muladd.jl:247
    [3] muladd!(α::Float64, A::Matrix{ComplexF64}, B::SubArray{ComplexF64, 2, Matrix{ComplexF64}, Tuple{UnitRange{Int64}, Base.OneTo{Int64}}, false}, β::Float64, C::SubArray{ComplexF64, 2, Matrix{ComplexF64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false})
      @ ArrayLayouts ~/.julia/packages/ArrayLayouts/O51Gr/src/muladd.jl:70
@dlfivefifty
Copy link
Member

Is this broken in tests? I’ve been testing on Julia v1.7 without issue so far. So if it’s not being triggered by the tests is there a MWE?

@mfherbst
Copy link

Simple reproducer extracted from the test case in DFTK mentioned by @vchuravy:

using BlockArrays
X = randn(ComplexF64, 8, 4)
Y = mortar((randn(8, 2), randn(8, 2)))
YX = Y'X
mul!(X, Y, YX, -1.0, 1.0)

Currently works fine on v1.6, but fails on v1.7.

@vchuravy
Copy link
Author

vchuravy commented Nov 3, 2021

Thanks @mfherbst for posting the reproducer.

@KristofferC
Copy link

I've removed this from the 1.6 backport branch since we try to be quite conservative there, even with internals like this.

@dlfivefifty
Copy link
Member

MWE

        X = randn(ComplexF64, 8, 4)
        Y = randn(8, 2)
        mul(Y',X)

dlfivefifty added a commit that referenced this issue Nov 12, 2021
* Remove usage of buffers

* v0.7.8
@vchuravy
Copy link
Author

vchuravy commented Dec 6, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants