Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise names to factorize_layout, inv_layout, etc. and use inv_l… #236

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

dlfivefifty
Copy link
Member

…ayout with Triangular

@DanielVandH this should help resolve JuliaArrays/LazyArrays.jl#320

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (f9fd686) to head (8391638).
Report is 3 commits behind head on master.

Files Patch % Lines
src/factorizations.jl 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   90.00%   90.47%   +0.47%     
==========================================
  Files          11       11              
  Lines        1900     1901       +1     
==========================================
+ Hits         1710     1720      +10     
+ Misses        190      181       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty dlfivefifty requested a review from jishnub June 22, 2024 07:48
@dlfivefifty dlfivefifty merged commit 8b9a0c1 into master Jun 25, 2024
18 checks passed
@dlfivefifty dlfivefifty deleted the dl/_layoutfuncs branch June 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining inverses for triangular matrices with ArrayLayouts
1 participant