Skip to content

Commit

Permalink
row/colsupport for QL/QRPackedQ (#62)
Browse files Browse the repository at this point in the history 
* row/colsupport for QL/QRPackedQ

* v2.1.3
  • Loading branch information
@dlfivefifty
dlfivefifty authored Apr 11, 2024
1 parent 423a683 commit 34fbcad
Show file tree
Hide file tree
Showing 7 changed files with 443 additions and 419 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/TagBot.yml
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
name: TagBot
on:
issue_comment:
issue_comment: # THIS BIT IS NEW
types:
- created
workflow_dispatch:
inputs:
lookback:
default: 3
permissions:
contents: write
jobs:
TagBot:
# THIS 'if' LINE IS NEW
if: github.event_name == 'workflow_dispatch' || github.actor == 'JuliaTagBot'
# NOTHING BELOW HAS CHANGED
runs-on: ubuntu-latest
steps:
- uses: JuliaRegistries/TagBot@v1
Expand Down
4 changes: 2 additions & 2 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "MatrixFactorizations"
uuid = "a3b82374-2e81-5b9e-98ce-41277c0e4c87"
version = "2.1.2"
version = "2.1.3"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand All @@ -9,7 +9,7 @@ Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"

[compat]
ArrayLayouts = "1.0"
ArrayLayouts = "1.9.2"
julia = "1.9"

[extras]
Expand Down
4 changes: 2 additions & 2 deletions src/MatrixFactorizations.jl
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module MatrixFactorizations
using Base, LinearAlgebra, ArrayLayouts
import Base: axes, axes1, getproperty, iterate, tail
import Base: axes, axes1, getproperty, iterate, tail, oneto
import LinearAlgebra: BlasInt, BlasReal, BlasFloat, BlasComplex, axpy!,
copy_oftype, checksquare, adjoint, transpose, AdjOrTrans, HermOrSym,
det, logdet, logabsdet, isposdef
Expand Down Expand Up @@ -34,7 +34,7 @@ import Base: convert, size, view, unsafe_indices,
import ArrayLayouts: reflector!, reflectorApply!, materialize!, @_layoutlmul, @_layoutrmul,
MemoryLayout, adjointlayout, AbstractQLayout, QRPackedQLayout,
QRCompactWYQLayout, AdjQRCompactWYQLayout, QRPackedLayout, AdjQRPackedQLayout,
layout_getindex
layout_getindex, rowsupport, colsupport


export ul, ul!, ql, ql!, qrunblocked, qrunblocked!, UL, QL, reversecholesky, reversecholesky!, ReverseCholesky
Expand Down
6 changes: 6 additions & 0 deletions src/ql.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,12 @@ adjointlayout(::Type, ::QLPackedQLayout{SLAY,TLAY}) where {SLAY,TLAY} = AdjQLPac
MemoryLayout(::Type{<:QLPackedQ{<:Any,Mat,Tau}}) where {Mat,Tau} =
QLPackedQLayout{typeof(MemoryLayout(Mat)),typeof(MemoryLayout(Tau))}()

colsupport(::QLPackedQLayout, Q, j) = minimum(colsupport(Q.factors, j)):size(Q,1)
rowsupport(::QLPackedQLayout, Q, k) = oneto(maximum(rowsupport(Q.factors, k)))
colsupport(::AdjQLPackedQLayout, Q, j) = oneto(maximum(colsupport(Q'.factors, j)))
rowsupport(::AdjQLPackedQLayout, Q, k) = minimum(rowsupport(Q'.factors, k)):size(Q,2)



function materialize!(M::Lmul{<:QLPackedQLayout})
A,B = M.A, M.B
Expand Down
Loading

2 comments on commit 34fbcad

@dlfivefifty
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/104678

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.1.3 -m "<description of version>" 34fbcaded720950463253405a539ce16412f5007
git push origin v2.1.3

Please sign in to comment.