v2.0 #50
Merged
v2.0 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dl/reversecholesky #50 +/- ##
=====================================================
Coverage ? 89.11%
=====================================================
Files ? 7
Lines ? 1112
Branches ? 0
=====================================================
Hits ? 991
Misses ? 121
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Coverage fail is just because it removes some functionality. |
|
This is a breaking change so we'll just leave this here until there's enough stuff for v2.0 to be tagged. (I probably jumped the gun on v1.0) |
dlfivefifty
merged commit a4d13b2
into
JuliaLinearAlgebra:dl/reversecholesky
3 checks passed
dlfivefifty
added a commit
that referenced
this pull request
Jul 11, 2023
* Implement reverse cholesky * tests pass * Drop old versions * remove choleskyinv (#50) Co-authored-by: Sheehan Olver <solver@mac.com> * use col/rowsupport * adjust supports * add tests, make copy for bidiagonal case * fix tests * Update test_reversecholesky.jl * Update reversecholesky.jl --------- Co-authored-by: Timon Salar Gutleb <timon.gutleb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my understanding of the discussion in Issue #4 that the choleskyinv part of this package is redundant in terms of efficiency, so I suggest its removal.
resolves #4