Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify use of an atol when comparing to zero #692

Merged
merged 29 commits into from
Dec 25, 2023
Merged

Unify use of an atol when comparing to zero #692

merged 29 commits into from
Dec 25, 2023

Commits on Dec 14, 2023

  1. Unify atols in isapproxes.

    @kellertuer
    kellertuer committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    bbb6dd6 View commit details
    Browse the repository at this point in the history

  2. fix dispatch route for direction vector transport in Circle.

    @kellertuer
    kellertuer committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    e60fb14 View commit details
    Browse the repository at this point in the history

  3. Fix a space error.

    @kellertuer
    kellertuer committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    477feae View commit details
    Browse the repository at this point in the history

  4. Make the atol more generic/tolerant

    @kellertuer
    kellertuer committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d9d83cf View commit details
    Browse the repository at this point in the history

  5. Fix a small typo in symplectic stiefel and update project.toml and news.

    @kellertuer
    kellertuer committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b397d2a View commit details
    Browse the repository at this point in the history

  6. Fix essential manifold.

    @kellertuer
    kellertuer committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    8b57a5b View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c35aa83 View commit details
    Browse the repository at this point in the history

  2. Update our reference.

    @kellertuer
    kellertuer committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    1e9610b View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. fix an edge case of exp! on Julia 1.6

    @mateuszbaran
    mateuszbaran committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    5fa4eed View commit details
    Browse the repository at this point in the history

  2. comment out a test for now

    @mateuszbaran
    mateuszbaran committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    e7861d9 View commit details
    Browse the repository at this point in the history

  3. some fixes for ManifoldsBase 0.15.6

    @mateuszbaran
    mateuszbaran committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    b269660 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Adapt imports, remove the ones that are no longer defined since Manif… 

    …oldsBase 0.15.6

...but they were never overwritten anywhere anyways.
    @kellertuer
    kellertuer committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8aad681 View commit details
    Browse the repository at this point in the history

  2. Adapt statistics to new scheme (part 1).

    @kellertuer
    kellertuer committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a0aaa02 View commit details
    Browse the repository at this point in the history

  3. Improve deprecations.

    @kellertuer
    kellertuer committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0cfeca5 View commit details
    Browse the repository at this point in the history

  4. Improve formatting.

    @kellertuer
    kellertuer committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    869f0a3 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9f6f544 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. forgot one scaling in the mean.

    @kellertuer
    kellertuer committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b8de1d9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'kellertuer/fix-isapproxes' of github.com:JuliaManifolds… 

    …/Manifolds.jl into kellertuer/fix-isapproxes
    @kellertuer
    kellertuer committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f3f1359 View commit details
    Browse the repository at this point in the history

  3. Fix a typo and allow for dispatch on the method already for the alloc… 

    …ation median and mean.
    @kellertuer
    kellertuer committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    27b1bbb View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Fix statistics tests.

    @kellertuer
    kellertuer committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    c7fc451 View commit details
    Browse the repository at this point in the history

  2. reintroduce the correct default.

    @kellertuer
    kellertuer committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    f181e72 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2023

  1. remove unneccessary code cases, increase code coverage also for depre… 

    …cated cases.
    @kellertuer
    kellertuer committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    032a5d4 View commit details
    Browse the repository at this point in the history

  2. re-enable BVP test, but raise its tolerance slightly.

    @kellertuer
    kellertuer committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    70d5df8 View commit details
    Browse the repository at this point in the history

  3. Remove two unnecessary fallbacks.

    @kellertuer
    kellertuer committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    6244a6a View commit details
    Browse the repository at this point in the history

  4. Remove allocating code that is no longer necessary on rotations.

    @kellertuer
    kellertuer committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    f8080e2 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Dec 24, 2023
    Configuration menu
    Copy the full SHA
    4c05d8e View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Dec 24, 2023
    Configuration menu
    Copy the full SHA
    3d9c861 View commit details
    Browse the repository at this point in the history

  7. Revert deletion of two methods of parallel_transport_direction and … 

    …add tests
    @mateuszbaran
    mateuszbaran committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    f95584f View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. fix changelog.

    @kellertuer
    kellertuer committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    a63e8ae View commit details
    Browse the repository at this point in the history