Basis number system swap

[mateuszbaran]

The solution of #204 we discussed today. The code seems to work locally but maybe documentation needs to be updated a bit more.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (30d587b) to head (082b592).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   99.90%   99.90%   -0.01%     
==========================================
  Files          31       31              
  Lines        3302     3301       -1     
==========================================
- Hits         3299     3298       -1     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kellertuer]

You were right today, a few things seem to indeed get nicer. Can you also check how much actually breaks with Manifolds.jl downstream?

[kellertuer]

In general I can check how well this is described in the docs page about bases and improve that somewhen tomorrow.

[mateuszbaran]

You were right today, a few things seem to indeed get nicer. Can you also check how much actually breaks with Manifolds.jl downstream?

Sure, I will make another PR to Manifolds.jl with adjustments.

In general I can check how well this is described in the docs page about bases and improve that somewhen tomorrow.

Thanks!

[kellertuer]

Besides the type of real coefficients being complex (see point above) this in general looks good to me.

[mateuszbaran]

OK, I've addressed that issue.