Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
  • Loading branch information
kellertuer and mateuszbaran authored May 7, 2024
1 parent c060302 commit 88d81f1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/plans/vectorial_plan.jl
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,15 @@ power manifold with a certain [`AbstractPowerRepresentation`](@extref).
PowerManifoldVectorialType(representation::AbstractPowerRepresentation)
"""
struct PowerManifoldVectorialType{<:AbstractPowerRepresentation} <: AbstractVectorialType end
struct PowerManifoldVectorialType{TPR<:AbstractPowerRepresentation} <: AbstractVectorialType
power_representation::TPR
end
PowerManifoldVectorialType(::TPR) = PowerManifoldVectorialType{TPR}()

@doc raw"""
VectorGradientFunction{E, FT, JT, F, J, I} <: <: AbstractManifoldObjective{E}
Represent a function ``f:\mathcal M → \mathbb R^n`` including its gradient.
Represent a function ``f:\mathcal M → \mathbb R^n`` including its gradient with respect to each component.
# Representations of ``f``
Expand Down Expand Up @@ -110,7 +112,7 @@ For the [`FunctionVectorialType`](@ref) ``f`` there are two different variants p
* `costs!!`: the cost function ``f``, which can take different formats
* `cost_type`: indicating / string data for the type of `f`
* `jacobian!!: the jacobian of ``f``
* `jacobian_type`: indicating / stpring data for the type of ``J_f``
* `jacobian_type`: indicating / storing data for the type of ``J_f``
* `parameters`: the nunmber `n` from above, that is the size of the vector ``f`` returns.
# Constructor
Expand Down

0 comments on commit 88d81f1

Please sign in to comment.