Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies. #309

Merged
merged 11 commits into from
Oct 25, 2023
Merged

Bump dependencies. #309

merged 11 commits into from
Oct 25, 2023

Conversation

kellertuer
Copy link
Member

To ManifoldsBase.jl 0.15 and Manifolds.jl 0.9

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #309 (b83e291) into master (d6acf64) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          77       76    -1     
  Lines        7090     7090           
=======================================
  Hits         7072     7072           
  Misses         18       18           
Files Coverage Δ
ext/ManoptManifoldsExt/ManoptManifoldsExt.jl 100.00% <ø> (ø)
src/Manopt.jl 87.50% <ø> (ø)
src/data/artificialDataFunctions.jl 100.00% <ø> (ø)
src/solvers/adaptive_regularization_with_cubics.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kellertuer
Copy link
Member Author

kellertuer commented Oct 24, 2023

Hm, this might be more complicated than I thought, since RecursiveArrays are a dependency of Manifolds but only a weak dependency of ManifoldsBAse, so the alternating gradient can actually not be moved out I think – and if so only into another weak dependency with RecursiveArrays since I need the ArrayPartition?

But I also get error messages slightly longer than Thomas Mann novels when anything in an Extension fails, so those are super hard to read.

@mateuszbaran
Copy link
Member

Yes, right, you can't just move the methods that require RecursiveArrayTools to Manopt.jl

Changelog.md Outdated Show resolved Hide resolved
kellertuer and others added 3 commits October 24, 2023 16:21
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
…lds/Manopt.jl into kellertuer/bump-dependencies
docs/Project.toml Outdated Show resolved Hide resolved
@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Oct 24, 2023
Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
@mateuszbaran
Copy link
Member

I think we could also add changelog to docs like in Manifolds.jl.

Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
@kellertuer
Copy link
Member Author

Yes, I can do that tomorrow morning.

@kellertuer kellertuer merged commit 7563b32 into master Oct 25, 2023
14 checks passed
@kellertuer kellertuer deleted the kellertuer/bump-dependencies branch November 20, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants