Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ini_hex and ini_HEX on 1.6+ #37

Merged
merged 5 commits into from
Sep 18, 2022

Conversation

ToucheSir
Copy link
Contributor

Ref. JuliaLang/julia#32859, JuliaMath/DoubleFloats.jl#125. This is causing warnings downstream in CUDA.jl.

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Base: 61.00% // Head: 49.51% // Decreases project coverage by -11.48% ⚠️

Coverage data is based on head (7e7c81b) compared to base (0632885).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #37       +/-   ##
===========================================
- Coverage   61.00%   49.51%   -11.49%     
===========================================
  Files           4        3        -1     
  Lines         100      103        +3     
===========================================
- Hits           61       51       -10     
- Misses         39       52       +13     
Impacted Files Coverage Δ
src/printf.jl 25.00% <62.50%> (-58.34%) ⬇️
src/bfloat16.jl 63.88% <0.00%> (-1.91%) ⬇️
src/BFloat16s.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ToucheSir ToucheSir changed the title Remove ini_hex and ini_HEX Remove ini_hex and ini_HEX on 1.6+ Jan 22, 2022
@ToucheSir
Copy link
Contributor Author

Bump on this. One other thing I was considering was adding more versions to the test matrix (1.6 and latest stable), but didn't want to blow up the test matrix size too much. If there are any suggestions there, happy to add them to this or a follow-up PR.

@ToucheSir
Copy link
Contributor Author

Bump again? This may be causing intermittent failures on FluxML CI: FluxML/Metalhead.jl#142

@JeffreySarnoff JeffreySarnoff merged commit 7335ea2 into JuliaMath:master Sep 18, 2022
@ToucheSir
Copy link
Contributor Author

Thanks @JeffreySarnoff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants