Fix constructor of ScaledSobolSeq #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add next!(s::ScaledSobolSeq) to allow for iteration over ScaledSobolSeq
moritzdrechselgrau
force-pushed
the
mdg/scaledsobol
branch
from
8b24950
to
46e5ac7
Compare
…aledSobolSeq directly, support AbstractVector
stevengj
reviewed
Jan 24, 2019
src/Sobol.jl
Outdated
| end | ||
| SobolSeq(N::Integer, lb, ub) = | ||
| ScaledSobolSeq{Int(N)}(copy!(Vector{Float64}(undef,N), lb), copy!(Vector{Float64}(undef,N), ub)) | ||
| function ScaledSobolSeq(lb::Vector{<:Real}, ub::Vector{<:Real}) |
stevengj
reviewed
Jan 24, 2019
src/Sobol.jl
Outdated
| @@ -122,11 +122,19 @@ struct ScaledSobolSeq{N} <: AbstractSobolSeq{N} | |||
| s::SobolSeq{N} | |||
| lb::Vector{Float64} | |||
| ub::Vector{Float64} | |||
| ScaledSobolSeq(lb::Vector{Float64}, ub::Vector{Float64}) = | |||
| function ScaledSobolSeq(N::Integer, lb::Vector{<:Real}, ub::Vector{<:Real}) | |||
There was a problem hiding this comment.
The right thing to do is to use ScaledSobolSeq{N}(...) where {N} for the inner constructor here. (This changed in Julia 0.7, which is why this code stopped working.)
|
Thanks for catching this! I pushed commit that modifies this PR a bit as commented above. |
|
Awesome, thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following example from the README did not work:
SobolSeq(2, [-1,0,0],[1,3,2])I added
Nto the arguments of the inner constructor.