Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #920

Merged
merged 11 commits into from
Dec 8, 2023
Merged

Misc changes #920

merged 11 commits into from
Dec 8, 2023

Conversation

epolack
Copy link
Collaborator

@epolack epolack commented Dec 7, 2023

You can cherry pick from those commits (I can revert anything left unchecked)

@antoine-levitt
Copy link
Member

Sure, all of these look fine to me, thanks!

@epolack epolack force-pushed the testing branch 4 times, most recently from 68a8aab to 721819c Compare December 7, 2023 16:44
Copy link
Member

@mfherbst mfherbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

docs/make.jl Outdated
@@ -104,10 +103,13 @@ DFTKBRANCH = try LibGit2.branch(LibGit2.GitRepo(ROOTPATH)) catch end
DFTKGH = "github.com/JuliaMolSim/DFTK.jl"
DFTKREPO = DFTKGH * ".git"

# Set to `true` to disable some checks and cleanup.
DEBUG = !CONTINUOUS_INTEGRATION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why like this ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because locally some warnings may actually be alright (see makedocs).
But you're right, as it does not happen on the DFTK doc, I will revert the behaviour for this point.

@mfherbst mfherbst merged commit 2e0c645 into JuliaMolSim:master Dec 8, 2023
7 of 8 checks passed
@epolack epolack deleted the testing branch December 21, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants