-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc changes #920
Misc changes #920
Conversation
meaning of: Skip intermediate builds: always.
This reverts commit 6760fcf.
Sure, all of these look fine to me, thanks! |
68a8aab
to
721819c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
docs/make.jl
Outdated
@@ -104,10 +103,13 @@ DFTKBRANCH = try LibGit2.branch(LibGit2.GitRepo(ROOTPATH)) catch end | |||
DFTKGH = "github.com/JuliaMolSim/DFTK.jl" | |||
DFTKREPO = DFTKGH * ".git" | |||
|
|||
# Set to `true` to disable some checks and cleanup. | |||
DEBUG = !CONTINUOUS_INTEGRATION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why like this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because locally some warnings may actually be alright (see makedocs).
But you're right, as it does not happen on the DFTK doc, I will revert the behaviour for this point.
You can cherry pick from those commits (I can revert anything left unchecked)
for i = 1:n
find ./ -type f -name '*.jl' -not -path "*/FourierTransforms.jl/*" -exec sed -E -i 's/in ([0-9]+):/= \1:/g' {} \;