Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NIfTI2 header #77

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

calvinchai
Copy link
Contributor

No description provided.

@calvinchai
Copy link
Contributor Author

#69

@Tokazama
Copy link
Member

Similar to the other PR. This one especially needs tests. Since NIFTI2 isn't always used the same way as NIFTI1, we need to make sure that we carefully test that we are reading the correct bytes into each field. Although we'd like to ultimately ensure we can read all canonical field variants correctly in our tests, this requires some extra decision making on how to handle things like "intent" fields as a public API. For now an empty image with a header that we know is correct would be sufficient.

I know this is a good chunk of extra work but it will help us ensure we don't accidentally break your pipeline down the road unexpectedly.

@calvinchai
Copy link
Contributor Author

Hi, I have added the basic test to read and write the nifti2 file. Is there anything you want specifically to test further?

@calvinchai
Copy link
Contributor Author

Currently, the existing tests all pass so I think it does not break anything that exists already. I also added two lines to read and write a NIfTI-2 file to make sure no error exists.

@calvinchai
Copy link
Contributor Author

Hello @Tokazama, is there any update on this?

@Tokazama
Copy link
Member

Apologies for the wait. The last thing we need is a version bump to 0.6.1 in the Project.toml file. Then I can send out a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants