Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optmize the comparison with nothing and array iteration to get rid of warnings #78

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

calvinchai
Copy link
Contributor

No description provided.

@Tokazama
Copy link
Member

Can you elaborate on where you are getting these warnings from?

@calvinchai
Copy link
Contributor Author

The warnings are from the compiler. If you use editor like visual studio code, they will be underlined and show up in problems section

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.57%. Comparing base (f366930) to head (32e971f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   52.33%   51.57%   -0.77%     
==========================================
  Files           6        6              
  Lines         577      570       -7     
==========================================
- Hits          302      294       -8     
- Misses        275      276       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tokazama
Copy link
Member

This looks good to me. Just so it is on the record for this commit, some of this syntax represents stuff many years ago and the language has changed a bit. We should probably have a formatting test integrated into pull requests going forward.

@Tokazama Tokazama merged commit 477b4ac into JuliaNeuroscience:master Oct 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants