Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests on 1.10 #122

Merged
merged 1 commit into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/perf.jl
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ end
println("Right associative composition: $b_right")

@test b_default.allocs == 0
if VERSION >= v"1.7"
if VERSION >= v"1.10-"
@test_broken b_right.allocs == 0
elseif VERSION >= v"1.7"
@test b_right.allocs == 0
else
@test_broken right.allocs == 0
Expand Down
11 changes: 4 additions & 7 deletions test/test_core.jl
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,10 @@ end
((@optic _.b.a.b[end]), 4.0),
((@optic _.b.a.b[end÷2+1]), 4.0),
]
if VERSION < v"1.7"
@test begin
@inferred lens(obj)
@inferred set(obj, lens, val)
@inferred modify(identity, obj, lens)
true
end
if VERSION < v"1.7" || VERSION >= v"1.10-"
@inferred lens(obj)
@inferred set(obj, lens, val)
@inferred modify(identity, obj, lens)
else
@inferred lens(obj)
@inferred set(obj, lens, val)
Expand Down
Loading