Properties #24
Merged
Properties #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not at all! Feel free to implement any of your other ideas we discussed too, I think we are on the same page with all of this. I'll be busy with other things for a while anyway so that PR wont be finished for a while. I'll just rebase this in. I'm also glad that ConstructionBase PR is turning out to be more widely useful than it seemed at the time. |
aplavin
pushed a commit
to aplavin/Accessors.jl
that referenced
this pull request
Jun 8, 2022
Implement mapproperties in terms of setproperties and getproperties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rafaqz I hope I don't step on your toes with #23?