Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

Clean up sdp2 #46

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Clean up sdp2 #46

merged 1 commit into from
Jan 22, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 21, 2018

Use analytical solution and removes the dependency on MOIU.eachscalar and Base.SparseArrays (which has been moved to stdlib : JuliaLang/julia#25249).

@mlubin
Copy link
Member

mlubin commented Jan 21, 2018

We're going to need to use sparse arrays. Is the motivation for removing the dependency just to avoid using Compat?

@blegat
Copy link
Member Author

blegat commented Jan 21, 2018

There is not strong motivation, we can use Compat. I just found it convenient when I saw that I removed the last part that was using SparseArrays.

@blegat blegat merged commit a07b27c into master Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants