update deprecated Array constructor #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
master failures might be related to JuliaLang/julia#20084 altough I have not actively looked into this |
musm
commented
Jan 28, 2017
| @@ -194,7 +194,7 @@ end | |||
|
|
|||
| type Choices <: BuildStep | |||
| choices::Vector{Choice} | |||
| Choices() = new(Array(Choice,0)) | |||
| Choices() = new(Vector{Choice}()) | |||
There was a problem hiding this comment.
Choice[] is also possible here and below, not sure which you prefer?
There was a problem hiding this comment.
there's some discussion that Vector{T}() might get deprecated - hasn't happened yet, but evidently the zero arg form isn't loved by all
|
I feel like a lot of the inner constructors here are unnecessary |
musm
commented
Jan 28, 2017
| @@ -239,7 +239,7 @@ immutable SystemPaths <: DependencyProvider; end | |||
|
|
|||
| show(io::IO, ::SystemPaths) = print(io,"System Paths") | |||
|
|
|||
| using URIParser, Compat | |||
There was a problem hiding this comment.
module already has a using Compat so it is not needed to repeat it.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.