-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builder for Zstd #21
Conversation
Based on https://github.com/bicycle1885/ZstdBuilder Co-authored-by: Kenta Sato <bicycle1885@gmail.com>
Cool. Is it recommended to use this repository and its binaries instead of maintaining my own? |
Yes, I believe so. The general goal of Yggdrasil as I understand it is to be a central source of binaries. The benefit of having it in a monorepo is that all builders can be updated at once to reflect the newest advances in BinaryBuilder. |
I would like to encourage everyone to contribute to one giant repo of build recipes for the following reasons:
|
Thank you for clarification. That sounds a good idea, so I'm trying to move my XML2 builder here. #22 is the pull request. Perhaps I should move ZlibBuilder, too? |
Yes, I think moving |
OK, I will do. By the way, I have a question about binary files that depend on other binaries. I received this issue report a while ago, and I think this is caused by lacking zlib libraries in our libxml2's distributions. I supposed the dynamic libraries of libxml2 were shipped or statically linked with zlib because zlib is included in the builder script as a dependency. What would be the best way to make sure that libxml2 has access to our zlib? |
This will be fixed soon (I am demoing the next generation of Pkg+BinaryProvider in the Pkg call today, if you're interested to see it) but for the moment, you need to run the |
That's good to know. I'll wait for it since the issue is not so urgent to me. |
Based on https://github.com/bicycle1885/ZstdBuilder, cc @bicycle1885. Updated to the newest version of zstd.