Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch libgit2 permissions for clone on NFS #3274

Closed
wants to merge 1 commit into from
Closed

patch libgit2 permissions for clone on NFS #3274

wants to merge 1 commit into from

Conversation

pfitzseb
Copy link
Contributor

@pfitzseb pfitzseb commented Jul 6, 2021

@pfitzseb
Copy link
Contributor Author

pfitzseb commented Jul 6, 2021 •
edited
Loading

Not sure what to do about that FreeBSD build error, but https://stackoverflow.com/questions/46058050/unable-to-compile-unrecognized-relocation indicates that there's a binutils version mismatch.
Will be fixed by JuliaPackaging/BinaryBuilderBase.jl#158.

giordano
giordano reviewed Jul 6, 2021
View reviewed changes
L/LibGit2/bundled/patches/libgit2-nfs-permissions.patch
@@ -0,0 +1,13 @@
diff --git a/src/odb_pack.c b/src/odb_pack.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this patch be upstreamed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see: libgit2/libgit2#5935

@ViralBShah
Copy link
Member

I am guessing we'll want a newer version anyways. Closing.

@ViralBShah ViralBShah closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Libgit2 has problems cloning on NFS mounts
3 participants
@pfitzseb @ViralBShah @giordano